ulysses-you commented on a change in pull request #26466:
URL: https://github.com/apache/spark/pull/26466#discussion_r430206294
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -88,20 +91,35 @@ case class CreateTableLikeCommand(
sourceTableDesc.provider
}
+ val newStorage = if (fileFormat.inputFormat.isDefined) {
+ sourceTableDesc.storage.copy(
Review comment:
> yes
A little late, can we retain the source `CatalogTable.properties` ? And use
new properties to merge it.
Here is a case:
1. a hive table that use parquet and set tblproperties `parquet.compression`.
2. do spark `create table like`.
3. new table do not have the properties.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -88,20 +91,35 @@ case class CreateTableLikeCommand(
sourceTableDesc.provider
}
+ val newStorage = if (fileFormat.inputFormat.isDefined) {
+ sourceTableDesc.storage.copy(
Review comment:
> yes
@cloud-fan
A little late, can we retain the source `CatalogTable.properties` ? And use
new properties to merge it.
Here is a case:
1. a hive table that use parquet and set tblproperties `parquet.compression`.
2. do spark `create table like`.
3. new table do not have the properties.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -84,24 +93,36 @@ case class CreateTableLikeCommand(
provider
} else if (sourceTableDesc.tableType == CatalogTableType.VIEW) {
Some(sparkSession.sessionState.conf.defaultDataSourceName)
+ } else if (fileFormat.inputFormat.isDefined) {
+ Some(DDLUtils.HIVE_PROVIDER)
} else {
sourceTableDesc.provider
}
+ val newStorage = if (fileFormat.inputFormat.isDefined) {
+ fileFormat
+ } else {
+ sourceTableDesc.storage.copy(locationUri = fileFormat.locationUri)
+ }
+
// If the location is specified, we create an external table internally.
// Otherwise create a managed table.
- val tblType = if (location.isEmpty) CatalogTableType.MANAGED else
CatalogTableType.EXTERNAL
+ val tblType = if (newStorage.locationUri.isEmpty) {
+ CatalogTableType.MANAGED
+ } else {
+ CatalogTableType.EXTERNAL
+ }
val newTableDesc =
CatalogTable(
identifier = targetTable,
tableType = tblType,
- storage = sourceTableDesc.storage.copy(
- locationUri = location.map(CatalogUtils.stringToURI(_))),
+ storage = newStorage,
schema = sourceTableDesc.schema,
provider = newProvider,
partitionColumnNames = sourceTableDesc.partitionColumnNames,
- bucketSpec = sourceTableDesc.bucketSpec)
+ bucketSpec = sourceTableDesc.bucketSpec,
+ properties = properties)
Review comment:
@cloud-fan
A little late, can we retain the source CatalogTable.properties ? And use
new properties to merge it.
Here is a case:
a hive table that use parquet and set tblproperties parquet.compression.
do spark create table like.
new table do not have the properties.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -84,24 +93,36 @@ case class CreateTableLikeCommand(
provider
} else if (sourceTableDesc.tableType == CatalogTableType.VIEW) {
Some(sparkSession.sessionState.conf.defaultDataSourceName)
+ } else if (fileFormat.inputFormat.isDefined) {
+ Some(DDLUtils.HIVE_PROVIDER)
} else {
sourceTableDesc.provider
}
+ val newStorage = if (fileFormat.inputFormat.isDefined) {
+ fileFormat
+ } else {
+ sourceTableDesc.storage.copy(locationUri = fileFormat.locationUri)
+ }
+
// If the location is specified, we create an external table internally.
// Otherwise create a managed table.
- val tblType = if (location.isEmpty) CatalogTableType.MANAGED else
CatalogTableType.EXTERNAL
+ val tblType = if (newStorage.locationUri.isEmpty) {
+ CatalogTableType.MANAGED
+ } else {
+ CatalogTableType.EXTERNAL
+ }
val newTableDesc =
CatalogTable(
identifier = targetTable,
tableType = tblType,
- storage = sourceTableDesc.storage.copy(
- locationUri = location.map(CatalogUtils.stringToURI(_))),
+ storage = newStorage,
schema = sourceTableDesc.schema,
provider = newProvider,
partitionColumnNames = sourceTableDesc.partitionColumnNames,
- bucketSpec = sourceTableDesc.bucketSpec)
+ bucketSpec = sourceTableDesc.bucketSpec,
+ properties = properties)
Review comment:
@cloud-fan
A little late, can we retain the source CatalogTable.properties ? And use
new properties to merge it.
Here is a case:
1. a hive table that use parquet and set tblproperties parquet.compression.
2. do spark create table like.
3. new table do not have the properties.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -84,24 +93,36 @@ case class CreateTableLikeCommand(
provider
} else if (sourceTableDesc.tableType == CatalogTableType.VIEW) {
Some(sparkSession.sessionState.conf.defaultDataSourceName)
+ } else if (fileFormat.inputFormat.isDefined) {
+ Some(DDLUtils.HIVE_PROVIDER)
} else {
sourceTableDesc.provider
}
+ val newStorage = if (fileFormat.inputFormat.isDefined) {
+ fileFormat
+ } else {
+ sourceTableDesc.storage.copy(locationUri = fileFormat.locationUri)
+ }
+
// If the location is specified, we create an external table internally.
// Otherwise create a managed table.
- val tblType = if (location.isEmpty) CatalogTableType.MANAGED else
CatalogTableType.EXTERNAL
+ val tblType = if (newStorage.locationUri.isEmpty) {
+ CatalogTableType.MANAGED
+ } else {
+ CatalogTableType.EXTERNAL
+ }
val newTableDesc =
CatalogTable(
identifier = targetTable,
tableType = tblType,
- storage = sourceTableDesc.storage.copy(
- locationUri = location.map(CatalogUtils.stringToURI(_))),
+ storage = newStorage,
schema = sourceTableDesc.schema,
provider = newProvider,
partitionColumnNames = sourceTableDesc.partitionColumnNames,
- bucketSpec = sourceTableDesc.bucketSpec)
+ bucketSpec = sourceTableDesc.bucketSpec,
+ properties = properties)
Review comment:
Yes. I tested it.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -84,24 +93,36 @@ case class CreateTableLikeCommand(
provider
} else if (sourceTableDesc.tableType == CatalogTableType.VIEW) {
Some(sparkSession.sessionState.conf.defaultDataSourceName)
+ } else if (fileFormat.inputFormat.isDefined) {
+ Some(DDLUtils.HIVE_PROVIDER)
} else {
sourceTableDesc.provider
}
+ val newStorage = if (fileFormat.inputFormat.isDefined) {
+ fileFormat
+ } else {
+ sourceTableDesc.storage.copy(locationUri = fileFormat.locationUri)
+ }
+
// If the location is specified, we create an external table internally.
// Otherwise create a managed table.
- val tblType = if (location.isEmpty) CatalogTableType.MANAGED else
CatalogTableType.EXTERNAL
+ val tblType = if (newStorage.locationUri.isEmpty) {
+ CatalogTableType.MANAGED
+ } else {
+ CatalogTableType.EXTERNAL
+ }
val newTableDesc =
CatalogTable(
identifier = targetTable,
tableType = tblType,
- storage = sourceTableDesc.storage.copy(
- locationUri = location.map(CatalogUtils.stringToURI(_))),
+ storage = newStorage,
schema = sourceTableDesc.schema,
provider = newProvider,
partitionColumnNames = sourceTableDesc.partitionColumnNames,
- bucketSpec = sourceTableDesc.bucketSpec)
+ bucketSpec = sourceTableDesc.bucketSpec,
+ properties = properties)
Review comment:
Sure ~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
