dongjoon-hyun commented on a change in pull request #28635:
URL: https://github.com/apache/spark/pull/28635#discussion_r430143655
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -183,7 +183,6 @@ metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
metrics-json/4.1.1//metrics-json-4.1.1.jar
metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
minlog/1.3.0//minlog-1.3.0.jar
-mssql-jdbc/6.2.1.jre7//mssql-jdbc-6.2.1.jre7.jar
Review comment:
Oh, interesting. I didn't notice this.
@gaborgsomogyi . This is worth for minimizing Apache Spark 3.0.0
distribution.
Since this PR cannot land on `branch-3.0`, could you make another PR for
this dependency clean-up?
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -183,7 +183,6 @@ metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
metrics-json/4.1.1//metrics-json-4.1.1.jar
metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
minlog/1.3.0//minlog-1.3.0.jar
-mssql-jdbc/6.2.1.jre7//mssql-jdbc-6.2.1.jre7.jar
Review comment:
Oh, interesting. I didn't notice this.
@gaborgsomogyi . This is worth for backporting because it minimizes Apache
Spark 3.0.0 distribution.
Since this PR cannot land on `branch-3.0`, could you make another PR for
this dependency clean-up?
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -183,7 +183,6 @@ metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
metrics-json/4.1.1//metrics-json-4.1.1.jar
metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
minlog/1.3.0//minlog-1.3.0.jar
-mssql-jdbc/6.2.1.jre7//mssql-jdbc-6.2.1.jre7.jar
Review comment:
Do you know what was the root cause of this dependency?
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -183,7 +183,6 @@ metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
metrics-json/4.1.1//metrics-json-4.1.1.jar
metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
minlog/1.3.0//minlog-1.3.0.jar
-mssql-jdbc/6.2.1.jre7//mssql-jdbc-6.2.1.jre7.jar
Review comment:
I know you are joking. ;) But, that is an auto-generated file.
> I've just double checked and it has been added by a guy at 24 Nov 2019
##########
File path: dev/deps/spark-deps-hadoop-3.2-hive-2.3
##########
@@ -183,7 +183,6 @@ metrics-jmx/4.1.1//metrics-jmx-4.1.1.jar
metrics-json/4.1.1//metrics-json-4.1.1.jar
metrics-jvm/4.1.1//metrics-jvm-4.1.1.jar
minlog/1.3.0//minlog-1.3.0.jar
-mssql-jdbc/6.2.1.jre7//mssql-jdbc-6.2.1.jre7.jar
Review comment:
The PR failed at
https://github.com/apache/spark/pull/28640#issuecomment-633919385 .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
