seanli-rallyhealth commented on a change in pull request #28595:
URL: https://github.com/apache/spark/pull/28595#discussion_r429990211
##########
File path: python/pyspark/ml/clustering.py
##########
@@ -99,23 +99,13 @@ def numIter(self):
@inherit_doc
class _GaussianMixtureParams(HasMaxIter, HasFeaturesCol, HasSeed,
HasPredictionCol,
HasProbabilityCol, HasTol, HasAggregationDepth,
HasWeightCol,
- HasBlockSize):
+ HasBlockSize, HasK):
Review comment:
sounds like more meaningful name instead of short name: HasK. say,
HasNumOfClusters?
##########
File path: python/pyspark/ml/clustering.py
##########
@@ -99,23 +99,13 @@ def numIter(self):
@inherit_doc
class _GaussianMixtureParams(HasMaxIter, HasFeaturesCol, HasSeed,
HasPredictionCol,
HasProbabilityCol, HasTol, HasAggregationDepth,
HasWeightCol,
- HasBlockSize):
+ HasBlockSize, HasK):
Review comment:
need more meaningful name instead of short name: HasK. say,
HasNumClusters?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
