igreenfield commented on a change in pull request #28629:
URL: https://github.com/apache/spark/pull/28629#discussion_r430900652
##########
File path: core/src/main/scala/org/apache/spark/util/ThreadUtils.scala
##########
@@ -130,7 +225,15 @@ private[spark] object ThreadUtils {
*/
def newDaemonCachedThreadPool(prefix: String): ThreadPoolExecutor = {
val threadFactory = namedThreadFactory(prefix)
-
Executors.newCachedThreadPool(threadFactory).asInstanceOf[ThreadPoolExecutor]
+ MDCAwareThreadPoolExecutor.newCachedThreadPool(threadFactory)
+ }
+
+ /**
+ * Wrapper over newCachedThreadPool. Thread names are formatted as
prefix-ID, where ID is a
+ * unique, sequentially assigned integer.
+ */
+ def newCachedThreadPool(threadFactory: ThreadFactory): ThreadPoolExecutor = {
+ MDCAwareThreadPoolExecutor.newCachedThreadPool(threadFactory)
}
Review comment:
You right I will remove that one. it is not used here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
