cloud-fan commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r430936819
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -266,7 +267,15 @@ abstract class CastBase extends UnaryExpression with
TimeZoneAwareExpression wit
TypeCheckResult.TypeCheckSuccess
} else {
TypeCheckResult.TypeCheckFailure(
- s"cannot cast ${child.dataType.catalogString} to
${dataType.catalogString}")
+ if (child.dataType.isInstanceOf[NumericType] &&
dataType.isInstanceOf[TimestampType]) {
Review comment:
it's better to let users know why it's wrong and how to fix, in the
error message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
