kiszk commented on a change in pull request #28646:
URL: https://github.com/apache/spark/pull/28646#discussion_r430947682



##########
File path: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -244,6 +250,12 @@ private object DateTimeFormatterHelper {
           for (style <- unsupportedNarrowTextStyle if 
patternPart.contains(style)) {
             throw new IllegalArgumentException(s"Too many pattern letters: 
${style.head}")
           }
+          if (bugInStandAloneForm && (patternPart.contains("LLL") || 
patternPart.contains("qqq"))) {
+            throw new IllegalArgumentException("The current JDK has a bug to 
support stand-alone " +

Review comment:
       I see. It is familiar to me (and Kris) :). Got general feeling. No 
objection.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to