Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5058#discussion_r26661365
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/GeneralizedLinearAlgorithm.scala
---
@@ -142,6 +147,11 @@ abstract class GeneralizedLinearAlgorithm[M <:
GeneralizedLinearModel]
protected def createModel(weights: Vector, intercept: Double): M
/**
+ * Get if the algorithm uses addIntercept
+ */
+ def isAddIntercept: Boolean = this.addIntercept
--- End diff --
Heh, `should` is more natural although I'm used to `is` or `get` for
getters in Java. I had the same reaction but think `is`is OK. It's more
obviously a getter to my eyes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
