viirya commented on a change in pull request #28647:
URL: https://github.com/apache/spark/pull/28647#discussion_r431428218
##########
File path:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2632,7 +2632,6 @@ class HiveDDLSuite
assert(source.properties("a") == "apple")
sql("CREATE TABLE t LIKE s STORED AS parquet TBLPROPERTIES('f'='foo',
'b'='bar')")
val table = catalog.getTableMetadata(TableIdentifier("t"))
- assert(table.properties.get("a") === None)
Review comment:
Based on the description of `CreateTableLikeCommand`:
> The CatalogTable attributes copied from the source table are
storage(inputFormat, outputFormat, serde, compressed, properties), schema,
provider, partitionColumnNames, bucketSpec by default.
So we don't say table properties are copied from source table too. Not sure
about why we didn't copy table properties.
I feel it is OK as seems copying original table properties should not be
harmful. And we already copy storage properties.
But we should update the doc together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
