viirya commented on a change in pull request #28661:
URL: https://github.com/apache/spark/pull/28661#discussion_r431622735
##########
File path: python/pyspark/sql/utils.py
##########
@@ -75,21 +96,29 @@ class UnknownException(CapturedException):
def convert_exception(e):
s = e.toString()
- stackTrace = '\n\t at '.join(map(lambda x: x.toString(),
e.getStackTrace()))
c = e.getCause()
+
+ jvm = SparkContext._jvm
+ jwriter = jvm.java.io.StringWriter()
+ e.printStackTrace(jvm.java.io.PrintWriter(jwriter))
+ stacktrace = jwriter.toString()
if s.startswith('org.apache.spark.sql.AnalysisException: '):
- return AnalysisException(s.split(': ', 1)[1], stackTrace, c)
+ return AnalysisException(s.split(': ', 1)[1], stacktrace, c)
if s.startswith('org.apache.spark.sql.catalyst.analysis'):
- return AnalysisException(s.split(': ', 1)[1], stackTrace, c)
+ return AnalysisException(s.split(': ', 1)[1], stacktrace, c)
if s.startswith('org.apache.spark.sql.catalyst.parser.ParseException: '):
- return ParseException(s.split(': ', 1)[1], stackTrace, c)
+ return ParseException(s.split(': ', 1)[1], stacktrace, c)
Review comment:
For some exceptions, like `ParseException`, it should be happened in
JVM, right? Is it good to show JVM stacktrace by default?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
