maropu commented on a change in pull request #28651: URL: https://github.com/apache/spark/pull/28651#discussion_r432195988
########## File path: sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/thrift/ThriftBinaryCLIService.java ########## @@ -76,6 +76,10 @@ public void run() { keyStorePassword, sslVersionBlacklist); } + // in case it is configured with 0 which represents any free port, we should set it to the Review comment: nit: `it` -> `HIVE_SERVER2_THRIFT_PORT ` for clarity. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org