cloud-fan commented on a change in pull request #28671:
URL: https://github.com/apache/spark/pull/28671#discussion_r432243974
##########
File path:
sql/hive-thriftserver/v1.2/src/main/java/org/apache/hive/service/cli/ColumnValue.java
##########
@@ -178,9 +178,9 @@ public static TColumnValue toTColumnValue(Type type, Object
value) {
case VARCHAR_TYPE:
return stringValue((HiveVarchar)value);
case DATE_TYPE:
- return dateValue((Date)value);
case TIMESTAMP_TYPE:
- return timestampValue((Timestamp)value);
Review comment:
shall we remove the `dateValue` and `timestampValue` methods?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
