imback82 commented on a change in pull request #28676: URL: https://github.com/apache/spark/pull/28676#discussion_r432910717
########## File path: sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala ########## @@ -554,7 +554,7 @@ class AdaptiveQueryExecSuite val smj = findTopLevelSortMergeJoin(plan) assert(smj.size == 2) val smj2 = findTopLevelSortMergeJoin(adaptivePlan) - assert(smj2.size == 2, origPlan.toString) + assert(smj2.size == 1, origPlan.toString) Review comment: This is not the right fix, and I am working on this to see if I can make the cost higher. For SMJ -> BHJ, it may not be possible with this PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org