viirya commented on a change in pull request #28681:
URL: https://github.com/apache/spark/pull/28681#discussion_r432913832
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -383,15 +383,26 @@ case class Invoke(
"""
}
+ val evalFunc = if (propagateNull) {
+ s"""
+ ${ev.isNull} = $resultIsNull;
+ if (!${ev.isNull}) {
+ $evaluate
+ }
+ """
+ } else {
+ s"""
+ ${ev.isNull} = false;
+ $evaluate
+ """
+ }
Review comment:
Do we need this? When `propagateNull` is false, in `prepareArguments`
`resultIsNull` will be set to false literal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
