TJX2014 commented on a change in pull request #28681:
URL: https://github.com/apache/spark/pull/28681#discussion_r432955834
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -366,11 +366,15 @@ case class Invoke(
// If the function can return null, we do an extra check to make sure
our null bit is still
// set correctly.
val assignResult = if (!returnNullable) {
- s"${ev.value} = (${CodeGenerator.boxedType(javaType)}) $funcResult;"
+ s"""
+ ${ev.value} = (${CodeGenerator.boxedType(javaType)}) $funcResult;
+ ${ev.isNull} = false;
+ """
} else {
s"""
if ($funcResult != null) {
${ev.value} = (${CodeGenerator.boxedType(javaType)}) $funcResult;
+ ${ev.isNull} = false;
Review comment:
Same as this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
