HeartSaVioR commented on a change in pull request #28391:
URL: https://github.com/apache/spark/pull/28391#discussion_r432995946
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/streaming/StreamingQueryListenerSuite.scala
##########
@@ -464,7 +470,59 @@ class StreamingQueryListenerSuite extends StreamTest with
BeforeAndAfter {
}
}
- private def testReplayListenerBusWithBorkenEventJsons(
+ test("SPARK-31593: remove unnecessary streaming query progress update") {
+ withSQLConf(SQLConf.STREAMING_NO_DATA_PROGRESS_EVENT_INTERVAL.key ->
"100") {
+ @volatile var numProgressEvent = 0
+ val listener = new StreamingQueryListener {
+ override def onQueryStarted(event: QueryStartedEvent): Unit = {}
+ override def onQueryProgress(event: QueryProgressEvent): Unit = {
+ numProgressEvent += 1
+ }
+ override def onQueryTerminated(event: QueryTerminatedEvent): Unit = {}
+ }
+ spark.streams.addListener(listener)
+ try {
+ val input = new MemoryStream[Int](0, sqlContext)
+ val clock = new StreamManualClock()
+ val result = input.toDF().select("value")
+ testStream(result)(
+ StartStream(trigger = Trigger.ProcessingTime(10), triggerClock =
clock),
+ AddData(input, 10),
+ AssertOnQuery { _ =>
Review comment:
Same pattern for 4 times - this can be deduplicated with inner method:
```
def verifyNumProgressEvent(expected: Int): AssertOnQuery = Execute { _ =>
eventually(Timeout(streamingTimeout)) {
assert(numProgressEvent == expected)
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
