iRakson commented on a change in pull request #28439:
URL: https://github.com/apache/spark/pull/28439#discussion_r433033635
##########
File path:
streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala
##########
@@ -17,30 +17,44 @@
package org.apache.spark.streaming.ui
-import scala.xml.Node
-
-import org.apache.spark.ui.{UIUtils => SparkUIUtils}
+import java.net.URLEncoder
+import java.nio.charset.StandardCharsets.UTF_8
+import javax.servlet.http.HttpServletRequest
-private[ui] abstract class BatchTableBase(tableId: String, batchInterval:
Long) {
+import scala.xml.Node
- protected def columns: Seq[Node] = {
- <th>Batch Time</th>
- <th>Records</th>
- <th>Scheduling Delay
- {SparkUIUtils.tooltip("Time taken by Streaming scheduler to submit
jobs of a batch", "top")}
- </th>
- <th>Processing Time
- {SparkUIUtils.tooltip("Time taken to process all jobs of a batch",
"top")}</th>
- }
+import org.apache.spark.ui.{PagedDataSource, PagedTable, UIUtils =>
SparkUIUtils}
+
+private[ui] class StreamingPagedTable(
+ request: HttpServletRequest,
+ tableTag: String,
+ batches: Seq[BatchUIData],
+ basePath: String,
+ subPath: String,
+ isRunningTable: Boolean,
+ isWaitingTable: Boolean,
+ isCompletedTable: Boolean,
Review comment:
Thank you suggesting this. I will change to constants.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
