maropu commented on a change in pull request #28683:
URL: https://github.com/apache/spark/pull/28683#discussion_r433036289
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2065,6 +2065,16 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val OPTIMIZER_HINTS_ENABLED =
+ buildConf("spark.sql.optimizer.hints.enabled")
+ .internal()
+ .doc("Hints are additional directives that aids optimizer in better
planning of a query. " +
+ "This configuration when set to `false`, disables the application of
user " +
+ "specified hints.")
Review comment:
nit: How about rephrasing it like this? (It seems the ohter similar
`.enabled` configs say `When true, brabrabra`)
```
When false, the optimizer will ignore user-specified hints that are
additional directives
for better planning of a query.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
