GuoPhilipse commented on pull request #28593:
URL: https://github.com/apache/spark/pull/28593#issuecomment-637205269
@cloud-fan
ParseToDate use the cast long to timestamp to realize the function, i am not
sure if it is the best design , but it is a remind point if we really want to
do sth on on dependent function.
`case class ParseToDate(left: Expression, format: Option[Expression], child:
Expression)
extends RuntimeReplaceable {
def this(left: Expression, format: Expression) {
this(left, Option(format),
Cast(Cast(UnixTimestamp(left, format), TimestampType), DateType))
}
def this(left: Expression) = {
// backwards compatibility
this(left, None, Cast(left, DateType))
}`
But, to be honest, it seems the change really affect too many modules in
spark, we plan to change the code directly, after we migrate ,we tell our user
to use the above three functions.Thanks @cloud-fan, @HyukjinKwon @maropu
@MaxGekk @bart-samwel for your warmly ,patient and relevant reviews,i really
got a lot from your reviews and points.
it is also my first time contributing to spark ,so the test flow is not so
familiar ,thanks for your kindly points .
Thanks again for you time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
