sarutak commented on a change in pull request #28690:
URL: https://github.com/apache/spark/pull/28690#discussion_r433638598
##########
File path: core/src/main/scala/org/apache/spark/ui/UIUtils.scala
##########
@@ -292,6 +292,7 @@ private[spark] object UIUtils extends Logging {
<html>
<head>
{commonHeaderNodes(request)}
+ <script>setAppBasePath('{activeTab.basePath}')</script>
Review comment:
At first, I considered the way you mention but to do so, we need to have
an additional parameter in `commonHeaderNodes` to pass `activeTab` only for
this purpose.
Which do you think is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
