cloud-fan commented on a change in pull request #28706:
URL: https://github.com/apache/spark/pull/28706#discussion_r433848010
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeFormatterHelper.scala
##########
@@ -227,6 +227,11 @@ private object DateTimeFormatterHelper {
formatter.format(LocalDate.of(2000, 1, 1)) == "1 1"
}
final val unsupportedLetters = Set('A', 'c', 'e', 'n', 'N', 'p')
+ // SPARK-31892: The week-based date fields are rarely used and really
confusing for parsing values
+ // to timestamp, especially when they are mixed with other non-week-based
ones. we have tried our
+ // best to restore the behavior change between 2.4 and 3.0 and failed, see
+ // https://github.com/apache/spark/pull/28674
Review comment:
We usually don't link PRs in the code comment. I think we can remove "We
have tried our ...."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
