Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/4610#discussion_r26726280
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/json/JSONRelation.scala ---
@@ -66,9 +66,21 @@ private[sql] class DefaultSource
mode match {
case SaveMode.Append =>
sys.error(s"Append mode is not supported by
${this.getClass.getCanonicalName}")
- case SaveMode.Overwrite =>
- fs.delete(filesystemPath, true)
+ case SaveMode.Overwrite => {
+ try {
+ if (!fs.delete(filesystemPath, true)) {
+ throw new IOException(
+ s"Unable to clear output directory
${filesystemPath.toString} prior"
+ + s" to INSERT OVERWRITE a JSON table:\n")
+ }
+ } catch {
+ case e: IOException =>
+ throw new IOException(
+ s"Unable to clear output directory
${filesystemPath.toString} prior"
+ + s" to INSERT OVERWRITE a JSON table:\n${e.toString}")
--- End diff --
This will also catch the one thrown by `try`. Can we avoid this? If
`delete` returns false, we just throw the exception after the `catch`. Also,
you can put `e` as the cause of the new exception, like `IOException("...", e)`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
