cloud-fan commented on a change in pull request #28593:
URL: https://github.com/apache/spark/pull/28593#discussion_r434305501
##########
File path: python/pyspark/sql/tests/test_dataframe.py
##########
@@ -604,7 +604,8 @@ def test_to_pandas_from_empty_dataframe(self):
@unittest.skipIf(not have_pandas, pandas_requirement_message)
def test_to_pandas_from_null_dataframe(self):
- with self.sql_conf({"spark.sql.execution.arrow.pyspark.enabled":
False}):
+ with self.sql_conf({"spark.sql.execution.arrow.pyspark.enabled": False,
+ "spark.sql.legacy.allowCastNumericToTimestamp":
True}):
Review comment:
why does this test fail? It casts null not numeric to timestamp.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
