viirya commented on a change in pull request #28686:
URL: https://github.com/apache/spark/pull/28686#discussion_r434828644
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionStateBuilder.scala
##########
@@ -82,8 +82,8 @@ class HiveSessionStateBuilder(session: SparkSession,
parentState: Option[Session
override val postHocResolutionRules: Seq[Rule[LogicalPlan]] =
new DetectAmbiguousSelfJoin(conf) +:
- new DetermineTableStats(session) +:
RelationConversions(conf, catalog) +:
+ new DetermineTableStats(session) +:
Review comment:
I mean previously `DetermineTableStats` will calculate table size and
update in `HiveTableRelation` before `RelationConversions`. Then in
`RelationConversions`, this calculated table size will be propagated into
`HadoopFsRelation` and used by `sizeInBytes`.
Now as you change the rule order, when running `RelationConversions`, even
users enable `fallBackToHdfsForStatsEnabled`, the `HadoopFsRelation` won't get
the table size calculated in `DetermineTableStats` (before it is run after
`RelationConversions` now).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
