maryannxue commented on a change in pull request #28676:
URL: https://github.com/apache/spark/pull/28676#discussion_r434999159
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala
##########
@@ -60,6 +60,26 @@ case class BroadcastHashJoinExec(
}
}
+ override def outputPartitioning: Partitioning = {
+ def buildKeys: Seq[Expression] = buildSide match {
+ case BuildLeft => leftKeys
+ case BuildRight => rightKeys
+ }
+
+ joinType match {
+ case _: InnerLike =>
+ streamedPlan.outputPartitioning match {
+ case h: HashPartitioning =>
+ PartitioningCollection(Seq(h, HashPartitioning(buildKeys,
h.numPartitions)))
Review comment:
Are you sure this is right??
Say "t1 join t2 on t1.a = t2.b" and t1 is partitioned on an unrelated column
"c", then we can say the join result is partitioned on "b" as well???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
