cloud-fan commented on a change in pull request #28728:
URL: https://github.com/apache/spark/pull/28728#discussion_r435406205
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateFormatter.scala
##########
@@ -126,7 +126,7 @@ object DateFormatter {
zoneId: ZoneId,
locale: Locale = defaultLocale,
legacyFormat: LegacyDateFormat = LENIENT_SIMPLE_DATE_FORMAT,
- isParsing: Boolean = true): DateFormatter = {
+ isParsing: Boolean): DateFormatter = {
Review comment:
shall we change back the parameter name? It's only needed in timestamp
formatter now, to indicate the fractional formatter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
