viirya commented on a change in pull request #28708:
URL: https://github.com/apache/spark/pull/28708#discussion_r435438297
##########
File path: core/src/main/scala/org/apache/spark/SparkContext.scala
##########
@@ -1725,6 +1725,16 @@ class SparkContext(config: SparkConf) extends Logging {
}
}
+
+ private[spark] def decommissionExecutors(executorIds: Seq[String]): Unit = {
+ schedulerBackend match {
+ case b: CoarseGrainedSchedulerBackend =>
+ executorIds.foreach(b.decommissionExecutor)
+ case _ =>
+ logWarning("Decommissioning executors is not supported by current
scheduler.")
Review comment:
Logging schedule name in logging message?
##########
File path: core/src/main/scala/org/apache/spark/MapOutputTracker.scala
##########
@@ -479,6 +497,16 @@ private[spark] class MapOutputTrackerMaster(
}
}
+ def updateMapOutput(shuffleId: Int, mapId: Long, bmAddress: BlockManagerId):
Unit = {
+ shuffleStatuses.get(shuffleId) match {
+ case Some(shuffleStatus) =>
+ shuffleStatus.updateMapOutput(mapId, bmAddress)
+ shuffleStatus.invalidateSerializedMapOutputStatusCache()
Review comment:
`ShuffleStatus.updateMapOutput` calls
`invalidateSerializedMapOutputStatusCache`, do we need calling it again here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
