holdenk commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639201319
> > > So @attilapiros looking at the Jenkins console logs we aren't leaking any threads during testing (nor would I expect us to). But I'll add something to more aggressively stop the shuffle migration threads. > > > > > > It will come when the `BlockManager` will be tested in `BlockManagerSuite`: > > ``` > > ===== POSSIBLE THREAD LEAK IN SUITE o.a.s.storage.BlockManagerSuite, thread names: rpc-boss-3-1, migrate-shuffle-to-BlockManagerId(exec2, localhost, 50804, None), shuffle-boss-9-1 , shuffle-boss-6-1 ===== > > ``` > > Gotcha was looking for the explicit decom test. I'll eagerly shutdown the migrate-shuffle-to threads then. I think the latest changes have fixed this (e.g. `grep "THREAD LEAK" consoleFull |grep BlockManager` returns nothing). Worth noting we do leak threads in ~283 tests so I'm not sure how important this is. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
