yaooqinn opened a new pull request #28738:
URL: https://github.com/apache/spark/pull/28738


   ### What changes were proposed in this pull request?
   
   This PR apply `SharedThriftServer` trait to all  ThriftServer related tests 
including 
   ```
   HiveThriftBinaryServerSuite
   HiveThriftCleanUpScratchDirSuite
   HiveThriftHttpServerSuite
   JdbcConnectionUriSuite
   SingleSessionSuite
   SparkMetadataOperationSuite
   SparkThriftServerProtocolVersionsSuite
   UISeleniumSuite
   ```
   `SharedThriftServer` can use a random free port to reduce the flakiness of 
these tests.
   
   This PR also re-enabled the `UISeleniumSuite` which has been ignored since 
2.0.
   
   
   ### Why are the changes needed?
   
   1. reduce the flakiness of tests.
   2. improve test coverage
   3. simplification
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as 
the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes 
- provide the console output, description and/or an example to show the 
behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to 
the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   no
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some 
test cases that check the changes thoroughly including negative and positive 
cases if possible.
   If it was tested in a way different from regular unit tests, please clarify 
how you tested step by step, ideally copy and paste-able, so that other 
reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why 
it was difficult to add.
   -->
   existing tests


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to