juliuszsompolski commented on pull request #28705: URL: https://github.com/apache/spark/pull/28705#issuecomment-639634143
> FYI, we run ThriftServerQueryTestSuite - SQL tests in sql/core/src/test/resources/sql-tests under Java 8 time API ON but SQLQueryTestSuite with Java 8 time API OFF. So, we run the same tests for both values of spark.sql.datetime.java8API.enabled. There is another difference in that SQLQueryTestSuite runs with Spark Dataframe API, so you collect the results directly using the Spark APIs, while ThriftServerQueryTestSuite runs it via JDBC connection and via Hive JDBC driver, so Date/Timestamps are being printed to string, and parsed back from String into java.sql.Date / java.sql.Timestamp by the Hive JDBC driver. So there is more differences than one running with Java 8 API ON, and the other with OFF. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
