attilapiros commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-639679228
> > > Oh also I think I understand some of our disagreement over the threads. I thought you were asking me to stop the Spark executor because I’ve started doing some separate work on that, and you were talking about the migration threads. Is my understanding correct now? > > > > > > Yes :) > > You can use the code from here if you agree with it: > > [#28708 (comment)](https://github.com/apache/spark/pull/28708#discussion_r434578445) > > I don't think we need that change, I believe setting running to false prevents the thread leak. If you run the test in the `BlockManagerSuite` then grep like this you will found the problem I have seen: ``` $ grep "THREAD LEAK" core/target/unit-tests.log |grep BlockManager ===== POSSIBLE THREAD LEAK IN SUITE o.a.s.storage.BlockManagerSuite, thread names: rpc-boss-3-1, shuffle-boss-9-1, migrate-shuffle-to-BlockManagerId(exec2, localhost, 49385, None), shuffle-boss-6-1 ===== ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
