huaxingao commented on a change in pull request #28710:
URL: https://github.com/apache/spark/pull/28710#discussion_r436316633
##########
File path: project/MimaExcludes.scala
##########
@@ -49,7 +49,34 @@ object MimaExcludes {
//[SPARK-31840] Add instance weight support in LogisticRegressionSummary
// weightCol in
org.apache.spark.ml.classification.LogisticRegressionSummary is present only in
current version
-
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.weightCol")
+
ProblemFilters.exclude[ReversedMissingMethodProblem]("org.apache.spark.ml.classification.LogisticRegressionSummary.weightCol"),
Review comment:
Before change, the code structure is like this:
```
sealed trait LogisticRegressionSummary extends Serializable
sealed trait LogisticRegressionTrainingSummary extends
LogisticRegressionSummary
sealed trait BinaryLogisticRegressionSummary extends
LogisticRegressionSummary
sealed trait BinaryLogisticRegressionTrainingSummary extends
BinaryLogisticRegressionSummary with LogisticRegressionTrainingSummary
```
So seems OK to me, no users can subclass the old traits.
Python seems OK to me too. I only added a new method. Applications written
for old versions of Spark shouldn't be affected by this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
