tgravescs commented on a change in pull request #28742:
URL: https://github.com/apache/spark/pull/28742#discussion_r436746988
##########
File path: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
##########
@@ -715,7 +715,9 @@ private[deploy] class Master(
val usableWorkers = workers.toArray.filter(_.state ==
WorkerState.ALIVE)
.filter(canLaunchExecutor(_, app.desc))
.sortBy(_.coresFree).reverse
- if (waitingApps.length == 1 && usableWorkers.isEmpty) {
+ val appMayHang = waitingApps.length == 1 &&
Review comment:
I think the idea of ==1 is that there is only 1 active application, if
more then 1, other applications could be using resources so unless you did a
lot more checking. We could definitely make it a more comprehensive check in
the future. I believe this was supposed to be a simple sanity check for people
playing around that may have started the cluster with not enough resources.
The standalone mode does not tell you there aren't enough and will just hang
forever.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
