gerashegalov commented on a change in pull request #28746:
URL: https://github.com/apache/spark/pull/28746#discussion_r437592878
##########
File path: core/src/main/scala/org/apache/spark/deploy/LocalSparkCluster.scala
##########
@@ -74,6 +74,10 @@ class LocalSparkCluster(
def stop(): Unit = {
logInfo("Shutting down local Spark cluster.")
+ // SPARK-31922: wait one more second before shutting down rpcEnvs of
master and worker,
+ // in order to let the cluster have time to handle the
`UnregisterApplication` message.
+ // Otherwise, we could hit "RpcEnv already stopped" error.
+ Thread.sleep(1000)
Review comment:
thanks for taking a look @Ngone51 . It's just a sample but, on my box
the issue has not shown up after the PR making sure the client is stopped only
after finishApplication and reworking the shutdown logic. Agree that perfecting
it comes at a price for minimum returns given it's a corner case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
