HeartSaVioR commented on pull request #28769: URL: https://github.com/apache/spark/pull/28769#issuecomment-641652906
Oh I was pointing out innocent one. `KVStoreView` is the culprit, though the class doc describes the warning. https://github.com/apache/spark/blob/master/common/kvstore/src/main/java/org/apache/spark/util/kvstore/KVStoreView.java Btw I'd rather not rely on finalize method - it's not guaranteed to be called. If there's a caller simply thinking finalize can deal with it, in my perspective that's a resource leak. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
