HeartSaVioR commented on pull request #28769: URL: https://github.com/apache/spark/pull/28769#issuecomment-641689379
Your example is the only case in the class explicitly closing the resource. All others are relying on the implementation of iterator. My bad on missing the implementation in LevelDBIterator. I’m not sure that is enough though - in many cases we leverage task completion listener to ensure closing of resource even the case of iterator, because of the previous observation. And my apologize that I might be confused with your comment - you may want to say for the proposal of the patch and I seem to misunderstand that that is for my comment. Looks like you’ve wanted to say about the patch itself. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
