gengliangwang commented on a change in pull request #28769:
URL: https://github.com/apache/spark/pull/28769#discussion_r437870387



##########
File path: 
common/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java
##########
@@ -276,6 +276,41 @@ public void testNegativeIndexValues() throws Exception {
     assertEquals(expected, results);
   }
 
+  @Test
+  public void testCloseLevelDBIterator() throws Exception {
+    // SPARK-31929: test when LevelDB.close() is called, related 
LevelDBIterators
+    // are closed. And files opened by iterators are also closed.
+    File dbpathForCloseTest = File
+            .createTempFile(

Review comment:
       please change to indents to two spaces in this file




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to