cloud-fan commented on a change in pull request #28766:
URL: https://github.com/apache/spark/pull/28766#discussion_r438145481
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/util/DatetimeFormatterSuite.scala
##########
@@ -17,15 +17,62 @@
package org.apache.spark.sql.catalyst.util
+import java.time.DateTimeException
+
import org.scalatest.Matchers
import org.apache.spark.{SparkFunSuite, SparkUpgradeException}
import org.apache.spark.sql.catalyst.plans.SQLHelper
+import org.apache.spark.sql.catalyst.util.DateTimeTestUtils.{date, UTC}
trait DatetimeFormatterSuite extends SparkFunSuite with SQLHelper with
Matchers {
import DateTimeFormatterHelper._
+ import LegacyDateFormats._
def checkFormatterCreation(pattern: String, isParsing: Boolean): Unit
+ private def dateFormatter(
+ pattern: String,
+ ldf: LegacyDateFormat = FAST_DATE_FORMAT): DateFormatter = {
Review comment:
super nit: we can put the parameters in one line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
