maropu commented on a change in pull request #28733:
URL: https://github.com/apache/spark/pull/28733#discussion_r438150199
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/predicates.scala
##########
@@ -198,6 +200,97 @@ trait PredicateHelper {
case e: Unevaluable => false
case e => e.children.forall(canEvaluateWithinJoin)
}
+
+ /**
+ * Convert an expression into conjunctive normal form.
+ * Definition and algorithm:
https://en.wikipedia.org/wiki/Conjunctive_normal_form
+ * CNF can explode exponentially in the size of the input expression when
converting Or clauses.
+ * Use a configuration MAX_CNF_NODE_COUNT to prevent such cases.
Review comment:
nit: `MAX_CNF_NODE_COUNT` ->` [[SQLConf.MAX_CNF_NODE_COUNT]]`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
