viirya commented on a change in pull request #28788:
URL: https://github.com/apache/spark/pull/28788#discussion_r438395914



##########
File path: 
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
##########
@@ -77,7 +79,7 @@ package object config {
       "a Hadoop installation separately.")
     .version("2.4.6")
     .booleanConf
-    .createWithDefault(true)
+    .createWithDefault(IS_HADOOP_PROVIDED)

Review comment:
       Curious about why a fixed default config value is not enough?

##########
File path: 
resource-managers/yarn/src/main/resources/org/apache/spark/deploy/yarn/config.properties
##########
@@ -0,0 +1 @@
+spark.yarn.populateHadoopClasspath = ${spark.yarn.populateHadoopClasspath}

Review comment:
       Do you actually mean `spark.yarn.isHadoopProvided` here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to