viirya commented on a change in pull request #28764:
URL: https://github.com/apache/spark/pull/28764#discussion_r438467090
##########
File path: sql/core/src/test/resources/sql-tests/inputs/operators.sql
##########
@@ -81,3 +81,17 @@ select positive('-1.11'), positive(-1.11),
negative('-1.11'), negative(-1.11);
-- pmod
select pmod(-7, 2), pmod(0, 2), pmod(7, 0), pmod(7, null), pmod(null, 2),
pmod(null, null);
select pmod(cast(3.13 as decimal), cast(0 as decimal)), pmod(cast(2 as
smallint), cast(0 as smallint));
+
+-- width_bucket
+select width_bucket(5.35, 0.024, 10.06, 5);
Review comment:
Let's add tests for edge cases like value == min, value == max, value <
min, value > max, etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
