dongjoon-hyun commented on a change in pull request #28788:
URL: https://github.com/apache/spark/pull/28788#discussion_r438474054
##########
File path:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/config.scala
##########
@@ -393,5 +395,19 @@ package object config {
private[yarn] val YARN_EXECUTOR_RESOURCE_TYPES_PREFIX =
"spark.yarn.executor.resource."
private[yarn] val YARN_DRIVER_RESOURCE_TYPES_PREFIX =
"spark.yarn.driver.resource."
private[yarn] val YARN_AM_RESOURCE_TYPES_PREFIX = "spark.yarn.am.resource."
-
+ lazy val IS_HADOOP_PROVIDED: Boolean = {
+ val configPath = "org/apache/spark/deploy/yarn/config.properties"
+ val propertyKey = "spark.yarn.isHadoopProvided"
+ try {
+ val prop = new Properties()
+ prop.load(ClassLoader.getSystemClassLoader.
+ getResourceAsStream(configPath))
+ prop.getProperty(propertyKey).toBoolean
+ } catch {
+ case e: Exception =>
+ log.warn(s"Can not load the default value of `$propertyKey` from " +
+ s"$configPath with error, ${e.toString}. Using false as a default
value."
+ false
Review comment:
But, what you mean is inconsistent with the PR title, `Only populate
Hadoop classpath for no-hadoop build`. This PR is trying to set
`IS_HADOOP_PROVIDED (false)` to `spark.yarn.populateHadoopClasspath` always for
Hadoop distribution too, isn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
