yaooqinn commented on a change in pull request #28751:
URL: https://github.com/apache/spark/pull/28751#discussion_r438606142



##########
File path: project/SparkBuild.scala
##########
@@ -480,7 +480,8 @@ object SparkParallelTestGrouping {
     "org.apache.spark.sql.hive.thriftserver.SparkSQLEnvSuite",
     "org.apache.spark.sql.hive.thriftserver.ui.ThriftServerPageSuite",
     "org.apache.spark.sql.hive.thriftserver.ui.HiveThriftServer2ListenerSuite",
-    "org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextSuite",
+    
"org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInHttpSuite",
+    
"org.apache.spark.sql.hive.thriftserver.ThriftServerWithSparkContextInBinarySuite",
     "org.apache.spark.sql.kafka010.KafkaDelegationTokenSuite"

Review comment:
       The root cause I found so far is: the spark session was stopped and 
detached from the thread-local variable, but the hive's SessionState was not, 
SO it gets reused next time which causes the newly defined configs in the new 
test file will not take effect.
   
   If what I‘ve found is the only issue that stops these tests from running 
together in a single JVM(verified locally and went well), I guess we can remove 
these 2 lines eventually.
   
   Sended a new PR, https://github.com/apache/spark/pull/28797 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to