yaooqinn commented on a change in pull request #28797:
URL: https://github.com/apache/spark/pull/28797#discussion_r438609711



##########
File path: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala
##########
@@ -50,14 +53,21 @@ trait SharedThriftServer extends SharedSparkSession {
       hiveServer2.stop()
     } finally {
       super.afterAll()
+      SessionState.detachSession()

Review comment:
       This fix is added to `SharedThriftServer ` not `SharedThriftServer` for 
a lower scope, but I think most of hive and `SharedSparkSession` tests that 
need a dedicated JVM may cause by this.

##########
File path: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SharedThriftServer.scala
##########
@@ -50,14 +53,21 @@ trait SharedThriftServer extends SharedSparkSession {
       hiveServer2.stop()
     } finally {
       super.afterAll()
+      SessionState.detachSession()

Review comment:
       This fix is added to `SharedThriftServer ` not `SharedThriftServer` for 
a lower scope, but I think most of hive and `SharedSparkSession` related tests 
that need a dedicated JVM may cause by this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to