zhli1142015 edited a comment on pull request #28769: URL: https://github.com/apache/spark/pull/28769#issuecomment-642344689
> Looks fine in general - one thing looks to be missed is, `LevelDBIterator.close()` should also call `db.closeIterator(this);` to make sure tracker can indicate it. @HeartSaVioR, thanks for your comments. I changed method name `closeIterator` to `notifyIteratorClosed` and remove `finalize` method as it's not needed any more. With this PR, `LevelDBIterator` should be closed either by explicit close call or DB.close. Then there would not be JNI resource leaking from it after DB is closed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
