zhli1142015 commented on a change in pull request #28769:
URL: https://github.com/apache/spark/pull/28769#discussion_r439177256
##########
File path:
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDB.java
##########
@@ -247,17 +266,28 @@ public void close() throws IOException {
}
}
+ public boolean isClosed() {
+ return this._db.get() == null;
+ }
+
/**
* Closes the given iterator if the DB is still open. Trying to close a JNI
LevelDB handle
* with a closed DB can cause JVM crashes, so this ensures that situation
does not happen.
*/
- void closeIterator(LevelDBIterator<?> it) throws IOException {
+ public void closeIterator(DBIterator it) throws IOException {
synchronized (this._db) {
DB _db = this._db.get();
if (_db != null) {
it.close();
}
}
+ iteratorTracker.remove(it);
+ }
+
+ public DBIterator createIterator() {
Review comment:
in my before commits, `LevelDBIterator` are tracked in `LevelDB` by
`iteratorTracker` to make sure they are correctly closed. I found GC would not
collect `LevelDBIterator` objects if caller doesn't explicit close it (remove
it from `iteratorTracker` ). So here is the change, let `LevelDB` tracks
`DBIterator`. Then GC sill works as before. when `LevelDBIterator.finalize` is
executed, `DBIterator` can be closed and removed from `iteratorTracker` .
As `DBIterator` would be closed in `LevelDB.close`, i think it's better to
keep one class to manage it. Now `LevelDBIterator.finalize` and
`LevelDBIterator.close` both finally calls `db.closeIterator`.
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
