srowen commented on a change in pull request #28786:
URL: https://github.com/apache/spark/pull/28786#discussion_r439608878
##########
File path:
mllib/src/test/scala/org/apache/spark/ml/regression/LinearRegressionSuite.scala
##########
@@ -899,6 +901,19 @@ class LinearRegressionSuite extends MLTest with
DefaultReadWriteTest with PMMLRe
}
}
+ test("linear regression training summary totalIterations") {
+ Seq(1, 5, 10, 20).foreach { maxIter =>
+ val trainer = new
LinearRegression().setSolver("l-bfgs").setMaxIter(maxIter)
+ val model = trainer.fit(datasetWithDenseFeature)
+ assert(model.summary.totalIterations <= maxIter)
+ }
+ Seq("auto", "normal").foreach { solver =>
+ val trainer = new LinearRegression().setSolver(solver)
+ val model = trainer.fit(datasetWithDenseFeature)
+ assert(model.summary.totalIterations === 0)
Review comment:
If no iterative optimizer was run, I think 0 makes sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
