karuppayya commented on a change in pull request #28804:
URL: https://github.com/apache/spark/pull/28804#discussion_r439710508
##########
File path:
sql/core/src/test/scala/org/apache/spark/sql/execution/WholeStageCodegenSuite.scala
##########
@@ -165,6 +166,26 @@ class WholeStageCodegenSuite extends QueryTest with
SharedSparkSession
}
}
+ test("SPARK-: Avoid spill in partial aggregation " +
+ "when spark.sql.aggregate.spill.partialaggregate.disabled is set") {
+ withSQLConf((SQLConf.SPILL_PARTIAL_AGGREGATE_DISABLED.key, "true"),
Review comment:
@maropu I figured out few more improvements taht can be made to the
generated code, I will test them and also addd the benchmark number.
Adding **WIP** tag to the title.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
