holdenk commented on pull request #28708: URL: https://github.com/apache/spark/pull/28708#issuecomment-643575581
Yeah so the plan is to trigger an exit as soon as migrations are completed. I think a good follow up to https://issues.apache.org/jira/browse/SPARK-31197 would be adding a timeout so we also just exit if were likely to be killed anyways by the underlying cluster manager (k8s/yarn/etc.). Also to make it a bit clearer I've put up two WIP PRs that build on top of this PR: https://github.com/apache/spark/pull/28818 & https://github.com/apache/spark/pull/28817 , there obviously a bit earlier on in terms of implementation/test coverage but I think they help illustrate some of the next steps. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
