holdenk commented on a change in pull request #28817:
URL: https://github.com/apache/spark/pull/28817#discussion_r439781436
##########
File path: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
##########
@@ -2039,8 +2047,11 @@ private[spark] class BlockManager(
* Class to handle block manager decommissioning retries
* It creates a Thread to retry offloading all RDD cache blocks
*/
- private class BlockManagerDecommissionManager(conf: SparkConf) {
+ private[spark] class BlockManagerDecommissionManager(conf: SparkConf) {
@volatile private var stopped = false
+ // Since running tasks can add more blocks this can change.
Review comment:
It is covered, you can verify this by disabling this logic and seeing
the test fail (albiet you'll have to run the test a few times because it
becomes a race condition). Look at the "migrateDuring" flag for details.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
