zhli1142015 commented on a change in pull request #28769:
URL: https://github.com/apache/spark/pull/28769#discussion_r439787366
##########
File path:
common/kvstore/src/test/java/org/apache/spark/util/kvstore/LevelDBSuite.java
##########
@@ -276,6 +277,41 @@ public void testNegativeIndexValues() throws Exception {
assertEquals(expected, results);
}
+ @Test
+ public void testCloseLevelDBIterator() throws Exception {
+ // SPARK-31929: test when LevelDB.close() is called, related
LevelDBIterators
+ // are closed. And files opened by iterators are also closed.
+ File dbPathForCloseTest = File
+ .createTempFile(
+ "test_db_close.",
+ ".ldb");
+ dbPathForCloseTest.delete();
+ LevelDB dbForCloseTest = new LevelDB(dbPathForCloseTest);
+ for (int i = 0; i < 8192; i++) {
+ dbForCloseTest.write(createCustomType1(i));
+ }
+ String key = dbForCloseTest
+ .view(CustomType1.class).iterator().next().key;
+ assertEquals("key0", key);
+ Iterator<CustomType1> it0 = dbForCloseTest
+ .view(CustomType1.class).max(1).iterator();
+ while(it0.hasNext()) {
+ it0.next();
+ }
+ System.gc();
+ Iterator<CustomType1> it1 = dbForCloseTest
+ .view(CustomType1.class).iterator();
+ assertEquals("key0", it1.next().key);
+ try(KVStoreIterator<CustomType1> it2 = dbForCloseTest
Review comment:
@HeartSaVioR , thanks for your review, updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
